Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming HTTP/3 "frame_type" to "type" #159

Closed
LPardue opened this issue Jun 30, 2021 · 3 comments
Closed

Consider renaming HTTP/3 "frame_type" to "type" #159

LPardue opened this issue Jun 30, 2021 · 3 comments

Comments

@LPardue
Copy link
Member

LPardue commented Jun 30, 2021

If I understand the schema correctly, I would produce something like this

["42.797","http","frame_created",{"stream_id":"12345","frame":{"frame_type":"data"},"length":"6789"}]

since frame_type is a property of the frame object, it seems redundant. Can we just use type instead?

@rmarx
Copy link
Contributor

rmarx commented Jul 1, 2021

We used to have just type or id for all similar fields, then (I think when moving to -02 or slightly before) I changed everything to have a more declarative name to make fields less reliant on context.

You could argue this is not needed for frame_type because it is indeed encapsulated in a top-level frame field, while it is still needed for stream_id because that's not immediately clear. Still, I personally somewhat prefer consistency here myself.

What would be your main argument for not keeping frame_type?

@rmarx
Copy link
Contributor

rmarx commented Aug 18, 2021

Ping @LPardue

@LPardue
Copy link
Member Author

LPardue commented Aug 18, 2021

I can live without this change, lets close it

@rmarx rmarx closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants