Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUICDatagramsSent or UDPDatagramsSent #323

Closed
rmarx opened this issue Jul 6, 2023 · 0 comments · Fixed by #407
Closed

QUICDatagramsSent or UDPDatagramsSent #323

rmarx opened this issue Jul 6, 2023 · 0 comments · Fixed by #407

Comments

@rmarx
Copy link
Contributor

rmarx commented Jul 6, 2023

We currently have several events that can be used to indicate how QUIC packets are sent in UDP datagrams (quic:datagrams_sent, quic:datagrams_received etc.).

However, adding support for RFC9221 (Unreliable Datagram extension for QUIC), which adds the new DatagramFrame, causes some issues with the naming here.

For example, we also want a datagram_data_moved event in addition to the existing (stream_)data_moved event, but that would be ambiguous which "datagram" we're actually talking about (UDP datagrams or QUIC Datagram Frames).

Since we've renamed the transport category to quic (before it was transport:datagrams_*), it makes sense to rename these events to udp:datagrams_* as well for consistency and clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant