Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The scenario of Figure 1 #114

Closed
kazu-yamamoto opened this issue Jul 14, 2022 · 4 comments
Closed

The scenario of Figure 1 #114

kazu-yamamoto opened this issue Jul 14, 2022 · 4 comments

Comments

@kazu-yamamoto
Copy link

I'm confused with the scenario of Figure 1:

Client                                          Server

   Chosen = A, Other Versions = (A, B) ----------------->
   <------------------------ Version Negotiation = (D, C)

   Chosen = C, Other Versions = (C, D) ----------------->
   <----------------- Chosen = D, Other Versions = (D, C)

The client chose C from VN.

When Other Versions is validated, the rule is:

The Other
Versions field is validated by confirming that the client would have
attempted the same version with knowledge of the versions the server
supports. That is, the client would have selected the same version
if it received a Version Negotiation packet that listed the versions
in the server's Other Versions field, plus the negotiated version.

So, this validation fails since the client would choose C.

@DavidSchinazi
Copy link
Contributor

In both cases, the client chose C. Attempted means "chose", not "negotiated".

@kazu-yamamoto
Copy link
Author

OK. So, the client checks the followings to prevent downgrade attack, right?

  • Check Other Versions so that the virtual second choice is the same as the first choice. (C in this case).
  • Check if Chosen is the same as the negotiated version after handshake. (D in this case).

@DavidSchinazi
Copy link
Contributor

That's correct

@kazu-yamamoto
Copy link
Author

Thanks. Now it's clear to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants