Set up linter rules for importing

slab · Feb 12, 2024 · 756d194 · 756d194
1 parent 891b30c
commit 756d194
Show file tree

Hide file tree

Showing 8 changed files with 36 additions and 23 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/quill/.eslintrc.json b/packages/quill/.eslintrc.json
@@ -1,5 +1,9 @@
 {
-  "extends": ["eslint:recommended", "plugin:prettier/recommended"],
+  "extends": [
+    "eslint:recommended",
+    "plugin:prettier/recommended",
+    "plugin:import/recommended"
+  ],
   "env": {
     "browser": true,
     "commonjs": true,
@@ -9,23 +13,28 @@
   "settings": {
     "import/resolver": {
       "webpack": {
-        "config": "webpack.config.ts"
-      }
+        "env": "development"
+      },
+      "typescript": true
     }
   },
   "ignorePatterns": ["*.js", "*.d.ts"],
   "overrides": [
     {
       "files": ["**/*.ts"],
-      "extends": ["plugin:@typescript-eslint/recommended"],
+      "extends": [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:import/typescript"
+      ],
       "excludedFiles": "*.d.ts",
       "plugins": ["@typescript-eslint"],
       "rules": {
         "@typescript-eslint/consistent-type-imports": "error",
         "@typescript-eslint/ban-ts-comment": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/ban-types": "off",
-        "@typescript-eslint/no-explicit-any": "off"
+        "@typescript-eslint/no-explicit-any": "off",
+        "import/no-named-as-default-member": "off"
       }
     }
   ]

diff --git a/packages/quill/package.json b/packages/quill/package.json
@@ -29,8 +29,9 @@
     "css-loader": "^6.8.1",
     "eslint": "^8.54.0",
     "eslint-config-prettier": "^9.0.0",
+    "eslint-import-resolver-typescript": "^3.6.1",
     "eslint-import-resolver-webpack": "^0.13.8",
-    "eslint-plugin-import": "^2.29.0",
+    "eslint-plugin-import": "^2.29.1",
     "eslint-plugin-jsx-a11y": "^6.8.0",
     "eslint-plugin-prettier": "^5.0.1",
     "highlight.js": "^9.18.1",

diff --git a/packages/quill/src/blots/scroll.ts b/packages/quill/src/blots/scroll.ts
@@ -3,10 +3,9 @@ import type { Blot, Parent, EmbedBlot, ParentBlot, Registry } from 'parchment';
 import Delta, { AttributeMap, Op } from 'quill-delta';
 import Emitter from '../core/emitter';
 import type { EmitterSource } from '../core/emitter';
-import Block, { BlockEmbed } from './block';
+import Block, { BlockEmbed, bubbleFormats } from './block';
 import Break from './break';
 import Container from './container';
-import { bubbleFormats } from './block';
 
 type RenderBlock =
   | {

diff --git a/packages/quill/src/core/emitter.ts b/packages/quill/src/core/emitter.ts
@@ -1,4 +1,4 @@
-import EventEmitter from 'eventemitter3';
+import { EventEmitter } from 'eventemitter3';
 import instances from './instances';
 import logger from './logger';
 

diff --git a/packages/quill/test/unit/modules/toolbar.spec.ts b/packages/quill/test/unit/modules/toolbar.spec.ts
@@ -1,9 +1,8 @@
 import { describe, expect, test } from 'vitest';
 import Quill from '../../../src/core/quill';
-import { addControls } from '../../../src/modules/toolbar';
+import Toolbar, { addControls } from '../../../src/modules/toolbar';
 import { normalizeHTML } from '../__helpers__/utils';
 import SnowTheme from '../../../src/themes/snow';
-import Toolbar from '../../../src/modules/toolbar';
 import Clipboard from '../../../src/modules/clipboard';
 import Keyboard from '../../../src/modules/keyboard';
 import History from '../../../src/modules/history';

diff --git a/packages/quill/webpack.config.ts b/packages/quill/webpack.config.ts
@@ -1,11 +1,10 @@
-import path from 'path';
 import { BannerPlugin, DefinePlugin } from 'webpack';
 import type { Configuration } from 'webpack';
 import common from './webpack.common';
 import { merge } from 'webpack-merge';
 import 'webpack-dev-server';
 import { readFileSync } from 'fs';
-import { join } from 'path';
+import { join, resolve } from 'path';
 
 const pkg = JSON.parse(readFileSync(join(__dirname, 'package.json'), 'utf8'));
 
@@ -30,7 +29,7 @@ export default (env: Record<string, unknown>) =>
     plugins: [bannerPack, constantPack],
     devServer: {
       static: {
-        directory: path.resolve(__dirname, './dist'),
+        directory: resolve(__dirname, './dist'),
       },
       hot: false,
       allowedHosts: 'all',

diff --git a/tsconfig.json b/tsconfig.json
@@ -1,4 +1,10 @@
 {
+  "ts-node": {
+    "compilerOptions": {
+      "esModuleInterop": true,
+      "module": "commonjs"
+    }
+  },
   "compilerOptions": {
     "allowSyntheticDefaultImports": true,
     "target": "ES2020",
@@ -9,7 +15,6 @@
     "noEmit": true,
     "strictNullChecks": true,
     "noImplicitAny": true,
-    "verbatimModuleSyntax": true,
     "noUnusedLocals": true
   },
   "include": ["./**/*"]