Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H1 toobar button doesn't respond to line change on mobile safari #1388

Closed
sheley1998 opened this issue Apr 1, 2017 · 0 comments
Closed

H1 toobar button doesn't respond to line change on mobile safari #1388

sheley1998 opened this issue Apr 1, 2017 · 0 comments

Comments

@sheley1998
Copy link

sheley1998 commented Apr 1, 2017

Update I suspect the issue is caused by the fact that toolbar buttons turn blue when mouse hovers over them. Mobile safari recognizes the first touch as hover, and whatever element is underneath the first touch will retain its styles defined with :hover until user touches somewhere else. I tried removing button:hover from qull.snow.css but that ended up making all toolbar buttons constantly blue. What is the proper way to remove hover styles from the css?

[Describe the issue]
H1 toobar button doesn't respond to line change in mobile safari

Steps for Reproduction
instantiate quill with the following code:

new Quill('#id', { modules : { toolbar : { container : [{ header : 1 }] } }, placeholder : 'Compose an epic...', theme : 'snow' });

(perform the following without touching the contenteditable area, otherwise bug could not be accurately reproduced)

open the page on mobile safari for iOS 10.3
click the h1 button in the toolbar
type something
press enter
type something else

Expected behavior:
since text on the second line isn't wrapped by h1 tags anymore, H1 button in the toolbar should become inactive and return to black instead of staying blue

Actual behavior:
H1 button stays blue, and won't return to black even if you press it again

Platforms:
mobile safari for iOS 10.3

Version:
v1.2.3

@jhchen jhchen closed this as completed in 08db54a May 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant