Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two problems with InlineEmbed blot input #1635

Closed
yetson opened this issue Aug 8, 2017 · 4 comments
Closed

Two problems with InlineEmbed blot input #1635

yetson opened this issue Aug 8, 2017 · 4 comments

Comments

@yetson
Copy link

yetson commented Aug 8, 2017

InlineEmbed blot seems not friendly to input, when input around the InlineEmbed blot, result is weird. Take formula blot for example as below:

Problem 1: left-side English letter input

Steps for Reproduction

  1. Visit quilljs.com
  2. focus left-side of the formula in the editor
  3. type 'ab' with keyboard

Expected behavior:
'ab' is on the left-side of the formula

Actual behavior:
'a' is on left, but 'b' right

2017-08-08 17 11 25

Problem 2: right-side Chinese letter input

Steps for Reproduction

  1. Visit quilljs.com
  2. focus right-side of the formula in the editor
  3. type 'zhong' to input '中' with Chinese input method

Expected behavior:
'中' is behind the formula blot

Actual behavior:
'z中' is behind the formula blot

2017-08-08 17 11 53

Platforms:
Google Chrome Version 60.0.3112.90 (Official Build) (64-bit)
Mac OS X EI Capitan Version 10.11.6

Version:
Quill.version is 1.3.1

@abramz
Copy link

abramz commented Aug 27, 2017

Your 2nd example seems to be working as intended.

The z is not made a part of the formula, that is not how embed blot works. You placed the cursor after the guard character, so the z comes after the formula. If you were expecting a space between the formula and the z, you have to type that yourself based on where you placed the cursor position.

jhchen added a commit that referenced this issue Aug 31, 2017
@ivanalejandro0
Copy link

I'm not able to reproduce "Problem 1", but it looks like it may be related to #2109

@qpxtWhite
Copy link

3136640D-71AF-4FE5-97DA-22E88BFAF046
I want “这是”, but it becomes “zh这是z”
How to fix the bug

@quill-bot
Copy link

Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants