Error when cursor places next to video embed

[benbro]

When I focus the editor in the beta-0 example I'm getting an error:
http://beta.quilljs.com/

TypeError: Argument 1 of Node.contains does not implement interface Node.
return parent.contains(descendant);
quill.js (line 5184, col 11)

Tested with Firefox 46.0.1 on Windows 7.

[earshinov]

@jhchen , Please, please, please change this

function contains(parent, descendant) {
  try {
    // Firefox inserts inaccessible nodes around video elements
    descendant.parentNode;
  } catch (e) {
    return false;
  }
  // IE11 has bug with Text nodes
  // https://connect.microsoft.com/IE/feedback/details/780874/node-contains-is-incorrect
  if (descendant instanceof Text) {
    descendant = descendant.parentNode;
  }
  return parent.contains(descendant);
}

into

function contains(parent, descendant) {
  try {
    // IE11 has bug with Text nodes
    // https://connect.microsoft.com/IE/feedback/details/780874/node-contains-is-incorrect
    if (descendant instanceof Text) {
      descendant = descendant.parentNode;
    }
    return parent.contains(descendant);
  } catch (e) {
    // Firefox inserts inaccessible nodes around video elements
    return false;
  }
}

A try..catch block containing nothing but e.parentNode gets optimized away by Angular compiler:

function g(t,e){return e instanceof Text&&(e=e.parentNode),t.contains(e)}

As a result, we still get the error from the issue description.

[earshinov]

Ah, nevermind. It is a known issue of the Angular compiler: angular/angular-cli#11439