Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter on empty list item creates api change instead of user change #739

Closed
benbro opened this issue Jun 8, 2016 · 2 comments
Closed

Enter on empty list item creates api change instead of user change #739

benbro opened this issue Jun 8, 2016 · 2 comments

Comments

@benbro
Copy link
Contributor

benbro commented Jun 8, 2016

[Describe the issue]
When pressing Enter in a line with empty list item, the list annotation is removed but the text-change event gets 'api' source instead of 'user' source.

Steps for Reproduction

  1. Visit http://beta.quilljs.com/
  2. select all text (ctrl+a) and remove it (backspace)
  3. write text-change source and delta in the console:
quill.on('text-change', function(delta, oldDelta, source) {
  console.log(source, delta);
});
  1. click on the ordered list button
  2. press Enter

Expected behavior: [expected]
All the text-change sources in the console should be 'user'

Actual behavior: [actual]
The last source is 'api'

Platforms:
Firefox 47 on Windows 7

Version: [version]
1.0-beta.4

@benbro
Copy link
Contributor Author

benbro commented Jun 8, 2016

It must be the quickest fix in the history of github :)

@benbro
Copy link
Contributor Author

benbro commented Jun 8, 2016

The clear formatting button has the same issue.
When selecting some text and clicking on the Tx button the text-change event source is 'api' instead of 'user'

To reproduce:

  1. Visit http://beta.quilljs.com/docs/formats/
  2. Click on the Bold (B) button
  3. type 'a'
  4. select the bold letter 'a'
  5. click on the clear formatting button Tx

The last text-change event has 'api' source

@jhchen jhchen closed this as completed in 6f519e6 Jun 8, 2016
jhchen added a commit that referenced this issue Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant