Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happened to uploaded images? #844

Closed
george-norris-salesforce opened this issue Aug 3, 2016 · 10 comments
Closed

What happened to uploaded images? #844

george-norris-salesforce opened this issue Aug 3, 2016 · 10 comments

Comments

@george-norris-salesforce

http://codepen.io/stoplion/pen/vKzrmK?editors=0010

Previously adding the image module gave me a prompt to upload from my computer now it is a prompt to add a URL.

@alexkrolick
Copy link
Contributor

Same here. Is this by design?

@willrowe
Copy link
Contributor

willrowe commented Aug 3, 2016

As far as I know Quill has never supported image upload. See #90.

@george-norris-salesforce
Copy link
Author

now you know :)
https://gyazo.com/338eb449ccf3e7e39748cc2b63f547d6

Last week lastest beta version had this feature..

@willrowe
Copy link
Contributor

willrowe commented Aug 3, 2016

Sorry, I assumed you were referring to the latest stable release since you didn't specify any version.
What you're talking about isn't exactly uploading any image. It is taking a file from your computer, converting it to a data URI, and inserting that into an image tag's src attribute. Related issue #103, related commit a615d52.

@george-norris-salesforce
Copy link
Author

george-norris-salesforce commented Aug 3, 2016

Gotcha.. What i mean is..

The behavior of the gif above presents a prompt to select an image from file system — presumably for uploading via Quill.

While the new (or old?) way assumes you have it already uploaded and are referencing it via URL.

@jhchen jhchen closed this as completed in 1ec6e6e Aug 3, 2016
@jhchen
Copy link
Member

jhchen commented Aug 3, 2016

Sorry guys a few issues can up from my refactoring of combining configurations and so the default theme handlers were not being copied over. Should have another beta out today.

@Muaadeeb
Copy link

Great tool but same question. Do we have an estimated date when image upload and/or drag & drop from your computer will be operational? I understand the image src current functionality but it would be nice if users could grab images from their own local drive.

@sumitkm
Copy link

sumitkm commented Oct 18, 2016

@Muaadeeb Ctrl+C Ctrl+V seems to work for me as does image drag drop (Firefox on Debian Jessie)... Just that you have to work out the details of converting the Base64 encoded image on the server side when you try to save the content.

@fghhfg
Copy link

fghhfg commented Oct 29, 2017

Ctrl+C Ctrl+V and drag n drop only work on firefox. unfortunately it doesn't work on chrome.
firefox implements some API that don't exist on chrome.

Do any polyfill library exist to make it works on chrome?

@daslicht
Copy link

How to make it not convert it to a data:image ?
I just want to select an image, and then a callback should be called so that i can handle the upload, after successful upload the image src should be set to the returned location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants