Generate the delta in a cursor-aware manner. #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,4 +1,5 @@ | |||
| _ = require('lodash') | |||
| Delta = require('rich-text/lib/delta') | |||
|
Great thanks for the PR! Just a few mostly stylistic changes requested in the inline comments. |
yyjhao
force-pushed
the
cursor_aware_delta
branch
3 times, most recently
from
1788245
to
fe861c8
Compare
| # TODO need to get this to prefer earlier insertions | ||
| delta = @delta.diff(newDelta) | ||
| return delta | ||
| diff = null |
This ensures that the delta is as close to the user's action as possible.
yyjhao
force-pushed
the
cursor_aware_delta
branch
from
fe861c8
to
377924b
Compare
jhchen
added a commit
that referenced
this pull request
May 29, 2015
Generate the delta in a cursor-aware manner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the delta is as close to the user's action as
possible.