Fix retention of formats between lines. #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some issues with the test, I'll take a look at it later. |
willrowe
force-pushed
the
fix-format-retention
branch
from
9e11eff
to
7be4d29
Compare
|
Any chance you could re-run the one job that timed out @jhchen? |
jhchen
added a commit
that referenced
this pull request
Jun 26, 2015
Fix retention of formats between lines.
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
fixes #386fixes the situation mentioned in #386 where a single enter will clear certain formats, while leaving others in place, it does not fix the double enter issue.There's a bug in this each loop when the CoffeeScript is converted to JavaScript. Since CoffeeScript always returns the last statement, it is returning the result of setting the format which can be false and will then drop out of the loop, not applying the remaining formats.
I also added a test to make sure that formatting is retained from now on.