Fix nested anchor tags after applying multiple link formats. #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyjhao
force-pushed
the
fix_link_double_format
branch
from
035bd9c
to
d98f442
Compare
|
It seems that the tests are flake - I have done a force push to trigger another round of tests and they fail for different tests. |
|
Yeah, the tests tend to timeout a lot and fail for reasons other than the tests not actually passing. |
|
Thanks for the PR! Sorry about the tests. Karma hardcodes a retry of 2 times and travis's connection to saucelabs is very flaky for mobile platforms. If all the other tests pass and the error is just a connectivity error then don't worry about it I'll check and rerun. |
jhchen
added a commit
that referenced
this pull request
Jul 2, 2015
Fix nested anchor tags after applying multiple link formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the bug: let's say we have text "abc", select "a", apply link "link1", then select "ab", apply link "link2" we will have the following markup:
<a href="link2"><a href="link1">a</a>b</a>c. This is malformed url as per html standard, plusquill.getContents()will return text with 2 urls rather than just 1.