Update styles dependencies #2255
Conversation
fiskus
commented
Jul 7, 2021
•
fiskus
commented
- highlight.js: 10.7.2 → 11.0.1
- katex: 0.13.5 → 0.13.11
- react-ace: 9.4.0 → 9.4.1
- remarkable: 1.7.4 → 2.0.1
- sanitize.css: 11.0.1 → 12.0.1
- vega-embed: 6.17.0 → 6.18.2
Codecov Report
@@ Coverage Diff @@
## master #2255 +/- ##
=======================================
Coverage 44.31% 44.31%
=======================================
Files 491 491
Lines 23462 23462
Branches 2987 2987
=======================================
Hits 10397 10397
Misses 12178 12178
Partials 887 887
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| import Remarkable from 'remarkable' | ||
| import { replaceEntities, escapeHtml, unescapeMd } from 'remarkable/lib/common/utils' | ||
| import * as Remarkable from 'remarkable' | ||
| import { linkify } from 'remarkable/linkify' |
There was a problem hiding this comment.
|
I opened dozen of Markdown files, and compared them to the same URLs on staging: the look the same |
|
If we don't have reference markdown file, I'll create one |
|
I noticed one change only, related to highlight.js: punctuation symbols become faded |
|
Before After |
you can even add different code samples there so we can test both MD rendering and code highlighting via single sample file |
that's fine, even nice |
|
@fiskus did you follow highlight.js migration guide? https://github.com/highlightjs/highlight.js/blob/main/VERSION_11_UPGRADE.md |
|
Yes, our code isn't affected by those changes |
|
I want to merge after GraphQL shipping |
