Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating angular cli to version 1.6.2 causes karma tests to fail #31

Closed
pimotte opened this issue Mar 18, 2018 · 2 comments · Fixed by #33
Closed

Updating angular cli to version 1.6.2 causes karma tests to fail #31

pimotte opened this issue Mar 18, 2018 · 2 comments · Fixed by #33

Comments

@pimotte
Copy link
Collaborator

pimotte commented Mar 18, 2018

Importing Web3 yields an undefined object in the unit tests.

I haven't figured out why this is yet. Issue showed up when I tried to update all packages to get rid of vulnerable packages.
@pimotte
Copy link
Collaborator Author

pimotte commented Mar 18, 2018

Code at https://github.com/Quintor/angular-truffle-box/tree/d9dd1347947f169c6610de50a2443c9c5fa76407

@pimotte
Copy link
Collaborator Author

pimotte commented Mar 18, 2018

Caused by angular/angular-cli#9058.

Using suggested import method causes typescript errors. angular-cli is forcing commonjs in dev builds, which I think, causes the breakage. This forcing has been removed, but only for the v6.0.0 build (which has webpack 4.0, which removes the need for the forcing).

Will likely wait for release of Angular 6.0 and then update the whole thing.

@pimotte pimotte mentioned this issue Apr 2, 2018
Merged
@pimotte pimotte mentioned this issue Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating versions of angular(-cli) Quintor/angular-truffle-box
1 participant
@pimotte