Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jboss EAP fingerprinter facts cleanup #1605

Closed
2 tasks
abaiken opened this issue Oct 15, 2018 · 0 comments
Closed
2 tasks

Jboss EAP fingerprinter facts cleanup #1605

abaiken opened this issue Oct 15, 2018 · 0 comments

Comments

@abaiken
Copy link
Contributor

abaiken commented Oct 15, 2018

Bug Description:

After doing a code review of the JBoss EAP fingerprinter, the eap_home_jboss_modules_manifest fact and the eap5_home_run_jar_manifest fact can never mark EAP as present as they were originally designed because of changes in our EAP_CLASSIFICATIONS dictionary.

Expected behavior:

eap_home_jboss_modules_manifest and eap5_home_run_jar_manifest should be able to mark EAP as present on a system if they have a certain value.

Actual behavior:

It is impossible for eap_home_jboss_modules_manifest or eap5_home_run_jar_manifest to mark EAP as present.

Steps to reproduce:

Look at the code in jboss_eap.py and specifically look at the functions is_eap_manifest_version and is_eap_jar_version


Acceptance Criteria:

  • Verify that eap_home_jboss_modules_manifest can mark EAP as present if it contains values specifying JBoss EAP
  • Verify that eap5_home_run_jar_manifest can mark EAP as present if it contains values specifying JBoss EAP

Version Information:

Build f661e28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants