-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extraneous newline added when no temporary headers specified #84
Comments
@ldionmarcil I was able to replicate this issue as well. Doing a little bit of troubleshooting, I was able to determine that when the "Temporary Headers" are blank, this is when the extra new line appears. This might rule out that the match/replace is the problem. |
Hi @terminalJunki3, sorry if my initial message wasn't clear:
you're correct, this occurs when the temporary headers are blank. The search & replace demonstration was merely to showcase that the extension otherwise works. |
|
@ldionmarcil just submitted a pull request that fixes this issue. Pull Request #87 Let me know if there is any issue with it. |
Fixes Bug #84 - extraneous newline at the end of requests
Fixed on 4e4d6f1 by @terminalJunki3 |
Hi, I noticed that Autorize adds an extraneous newline at the end of requests when no temporary headers are added. My use case was changing a cookie's value, without adding a header. Below shows an example of a simple match/replace:
With this configuration, Autorize would perform the string replace, but then it would add a newline at the bottom of the request:
Needless to say, this newline creates undesirable behaviours where an application expects a simple GET, but instead receives a fat GET (GET with a POST body). See screenshot below for responses, for previous screenshot's requests:
A current workaround is to add a dummy header, ie
Foo: Bar
, but I suppose many people won't figure this out until much debugging. Could this be fixed?Burp: 2022.1.1
Autorize: BApp store version
Tested on two different machines
The text was updated successfully, but these errors were encountered: