Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous newline added when no temporary headers specified #84

Closed
ldionmarcil opened this issue Mar 7, 2022 · 5 comments
Closed

Extraneous newline added when no temporary headers specified #84

ldionmarcil opened this issue Mar 7, 2022 · 5 comments

Comments

@ldionmarcil
Copy link

ldionmarcil commented Mar 7, 2022

Hi, I noticed that Autorize adds an extraneous newline at the end of requests when no temporary headers are added. My use case was changing a cookie's value, without adding a header. Below shows an example of a simple match/replace:

image

With this configuration, Autorize would perform the string replace, but then it would add a newline at the bottom of the request:

image

Needless to say, this newline creates undesirable behaviours where an application expects a simple GET, but instead receives a fat GET (GET with a POST body). See screenshot below for responses, for previous screenshot's requests:

image

A current workaround is to add a dummy header, ie Foo: Bar, but I suppose many people won't figure this out until much debugging. Could this be fixed?

Burp: 2022.1.1
Autorize: BApp store version
Tested on two different machines

@terminalJunki3
Copy link
Contributor

@ldionmarcil I was able to replicate this issue as well. Doing a little bit of troubleshooting, I was able to determine that when the "Temporary Headers" are blank, this is when the extra new line appears. This might rule out that the match/replace is the problem.

image

@ldionmarcil
Copy link
Author

ldionmarcil commented Mar 8, 2022

Hi @terminalJunki3, sorry if my initial message wasn't clear:

[...] Autorize adds an extraneous newline at the end of requests when no temporary headers are added

you're correct, this occurs when the temporary headers are blank. The search & replace demonstration was merely to showcase that the extension otherwise works.

@terminalJunki3
Copy link
Contributor

Hi @terminalJunki3, sorry if my initial message wasn't clear:

[...] Autorize adds an extraneous newline at the end of requests when no temporary headers are added

you're correct, this occurs when the temporary headers are blank. The search & replace demonstration was merely to showcase that the extension otherwise works.
@ldionmarcil Thank you sir for the clarification. I starting looking into this. Ill update this thread if I can find/add a fix.

@terminalJunki3
Copy link
Contributor

terminalJunki3 commented Mar 9, 2022

@ldionmarcil just submitted a pull request that fixes this issue. Pull Request #87 Let me know if there is any issue with it.

Quitten added a commit that referenced this issue Mar 9, 2022
Fixes Bug #84 - extraneous newline at the end of requests
@Quitten
Copy link
Owner

Quitten commented Mar 9, 2022

Fixed on 4e4d6f1 by @terminalJunki3
@ldionmarcil - please let me know if you still suffering this issue.
Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants