Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta3 #23

Closed
51 tasks done
qulle opened this issue Sep 15, 2022 · 0 comments · Fixed by #27
Closed
51 tasks done

Beta3 #23

qulle opened this issue Sep 15, 2022 · 0 comments · Fixed by #27
Assignees
Labels
bug Something isn't working code improvement Improvements or restructure of the code doing Working on this

Comments

@qulle
Copy link
Owner

qulle commented Sep 15, 2022

Small features:

  • Stamen Terrain map
  • Windbarb layer
  • Highlight vector shape when hover
  • Pan-and-zoom to MyLocation and open InfoWindow
  • Support for thin scrollbars using the class .oltb-thin-scrollbars
  • Subtracting intersections from drawn objects
  • Shape functionality, Union, Difference, Intersection, SymDifference
  • Updating color in the Edit Tool
  • Re-activate activated tool after application was reloaded

Refactoring:

  • Comments
  • Overall code quality
  • MomentaryActivation function for non-persistant tools
  • Module for creating feature tooltips
  • Reduce dependency between DirectionTool and general Tooltips
  • Directory naming, structure and hierarchy
  • Create URLManager
  • Create ToolManager, to remove global window.oltb
  • Collapsed toolboxes, class method
  • Consistent tool naming
  • Add click callback to all tools that is fired when the main tool-button is clicked
  • Consistent element ID-naming
  • Module for shortcut keys, as it is now, it is difficult to get an overview of who is already busy
    • modules/helpers/constants/ShortcutKeys.js
  • Module for ContextMenu instances
    • modules/helpers/constants/ContextMenus.js
  • Module for feature properties
    • modules/helpers/constants/FeatureProperties.js
  • Namespac (oltb) custom properties
  • Module for custom event-names, minimize errors coming from text literals
    • modules/helpers/constants/Events.js
  • Module for settings, minimize errors coming from text literals
    • modules/helpers/constants/Settings.js
  • Store references directly on the object and not in a const variable first
  • Consistent Fetch syntax
  • Consistent arrow-function/then/catch syntax when one argument
  • Create static Assert-class
  • Convert all anonymous functions in constructor to class methods
  • Make Uppercase CONST export/imports
  • Make Uppercase CONST variables outside classes
  • Use 4000ms as autoremove delay for Toast
  • Copy epsg files from ProjectionTool branch
  • Add pre defined projections to debug info window
  • Solution for not creating two features for FeatureMarkers
  • ScalieLine null declaration
  • ModalWindow last element margin-button, remove classes from Notification modal
  • Add accuracy and timeout properties to MyLocation constructor
  • Make DrawingTool default white bg-color with alpha same as MeasureTool

Bugs:

  • Measure tooltips is not removed when deleting a selected feature using the Edit-tool
  • MyLocation tool is triggered many times on button click and shortcut key
  • Notification tool is triggered many times when shortcut key is used
  • Info modal can be triggered many times when shortcut key is used
  • Debug tool is triggered many times when shortcut key is used
  • Unknown this.options in Contextmenu for Focus item
  • Space between spinner and text in Toasts
  • Close InfoWindow when a layer is removed
  • Measure tooltips are not exported in PNG (not a bug actually). Items that are not draw in the map canvas (normal HTML elements, known as Overlays) will not be picked up in the export. A merge between the map Canvas and the Canvas generated by html2canvas lib will fix this.
@qulle qulle self-assigned this Sep 15, 2022
@qulle qulle added code improvement Improvements or restructure of the code bug Something isn't working labels Sep 15, 2022
@qulle qulle added the doing Working on this label Sep 24, 2022
@qulle qulle linked a pull request Oct 19, 2022 that will close this issue
@qulle qulle closed this as completed in #27 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working code improvement Improvements or restructure of the code doing Working on this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant