Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hebrew Localization #56

Merged
merged 16 commits into from Feb 11, 2023
Merged

Hebrew Localization #56

merged 16 commits into from Feb 11, 2023

Conversation

thefourcraft
Copy link
Contributor

I added support for Hebrew, and also some commits to the build file :)

@qunash
Copy link
Collaborator

qunash commented Feb 11, 2023

Hi, thanks for the PR and for your effort in adding support for an additional language.

Just one request. The comments added to build.mjs don't add any value to the codebase. We should try to keep the code self-explanatory and minimize the use of comments whenever possible.

Could you revert the changes to build.mjs?

@thefourcraft
Copy link
Contributor Author

wow didn't notice that, I have a ChatGPT extension for my VS Code and it adds comments to code 🤣

@qunash
Copy link
Collaborator

qunash commented Feb 11, 2023

Thank you :)

@qunash qunash merged commit 742f28c into interstellard:dev Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants