Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUnit should keep a local reference to Date #283

Closed
Krinkle opened this issue Jul 16, 2012 · 1 comment · Fixed by #285
Closed

QUnit should keep a local reference to Date #283

Krinkle opened this issue Jul 16, 2012 · 1 comment · Fixed by #285

Comments

@Krinkle
Copy link
Member

Krinkle commented Jul 16, 2012

From qunitjs/node-qunit@4252119:

Since modules like node-timekeeper can modify it, node-qunit protects against this. Right now it does that by hacking the following line into qunit.js. Perhaps we should put it in the main repo here?

    Date = window.Date;
@jzaefferer
Copy link
Member

First time I hear of that issue, but I don't see a problem with patching that. PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants