Error when editing songs.

[lazka]

Original issue 1519 created by thisfred on 2015-01-08T05:39:51.000Z:

For a few weeks I've been occasionally getting this error when attempting to edit the metadata of a song. (I think it's always a single song, but I'm not 100% sure, and it doesn't always happen when editing a single song.)

Traceback (most recent call last):
File "/home/eric/quodlibet-trunk/quodlibet/quodlibet/util/init.py", line 659, in wrap
return handler(that, *args)
NameError: free variable 'handler' referenced before assignment in enclosing scope

I've looked at the code but I have a hard time seeing how the handler in the closure could be undefined, because it is passed in as an argument to the containing method. Magic, is what I suspect... ;)

Please let me know if I can provide more details.

[lazka]

Comment #1 originally posted by thisfred on 2015-01-08T05:44:35.000Z:

I should mention that the error doesn't seem to have any effect other than the error window popping up (and a traceback in the terminal, when running from there.) After hitting 'Cancel', editing seems to work as expected.

[lazka]

Comment #2 originally posted by reiter.christoph on 2015-01-08T10:32:01.000Z:

See 1515. I suspect it's some refcounting issue in pygobject.

Can you add how exactly you can trigger the error? The traceback doesn't include the cause in this case.

[lazka]

Comment #3 originally posted by ericc@simple.com on 2015-01-08T16:25:24.000Z:

It seems to happen (again, not consistently) when I select a single song (in the search view, since that's the only one I use, I don't know if it would happen in other views/browsers.) right click on it, and select 'Edit Tags'.

[lazka]

Comment #4 originally posted by reiter.christoph on 2015-01-08T17:51:03.000Z:

Could it be that this was fixed by https://code.google.com/p/quodlibet/source/detail?r=130973d883c18e77c as well (should be in the repos) ?

I can't reproduce it here :/

[lazka]

Comment #5 originally posted by ericc@simple.com on 2015-01-08T20:22:40.000Z:

Could be, I'm not seeing it at the moment either, though it happened maybe one in ten times, so it's hard to say for sure. I'm fine with assuming it's fixed and closing this issue. I will reopen if it happens again?

[lazka]

Comment #6 originally posted by reiter.christoph on 2015-01-08T20:28:22.000Z:

Thanks, sounds good.