Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLLD solver does not compute flux for Eint #527

Open
BenWibking opened this issue Feb 6, 2024 · 0 comments
Open

HLLD solver does not compute flux for Eint #527

BenWibking opened this issue Feb 6, 2024 · 0 comments
Labels
bug Something isn't working MHD
Milestone
MHD

Comments

@BenWibking
Copy link
Collaborator

Describe the bug
The HLLD solver sets the flux for the auxiliary internal energy variable to zero:

quokka/src/HLLD.hpp

Line 329 in edc1dbc

// TODO(neco): Eint=0 for now; pscalars will also be needed in the future.

Within the Riemann solver, the auxiliary internal energy should be treated the same as a passive scalar.

Additional context
High-mach flows will not work correctly with MHD until this is fixed.
@BenWibking BenWibking added bug Something isn't working MHD labels Feb 6, 2024
@BenWibking BenWibking added this to the MHD milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working MHD
Projects
None yet
Milestone
MHD
Development

No branches or pull requests
1 participant
@BenWibking