Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CI testing for HLLD solver #529

Open
BenWibking opened this issue Feb 6, 2024 · 0 comments
Open

add CI testing for HLLD solver #529

BenWibking opened this issue Feb 6, 2024 · 0 comments
Labels
enhancement New feature or request MHD
Milestone

Comments

@BenWibking
Copy link
Collaborator

Describe the proposal
We should add a CI test run that compiles and runs the 1D hydro test problems with the HLLD solver (with B=0). This will ensure that the MHD solver is at least as well tested as the hydro solver, and that we do not regress on any of the existing hydro test problems.

Describe alternatives you've considered
The alternative would be to create MHD versions of all of the existing hydro test problems, but that would be laborious and unnecessary if we could were able to recompile and run the hydro problems with the HLLD solver.

Additional context
There are currently subtle differences between the HLLC and HLLD solvers involving the wavespeeds as well as the carbuncle fix. For the latter, see #528.

@BenWibking BenWibking added enhancement New feature or request MHD labels Feb 6, 2024
@BenWibking BenWibking added this to the MHD milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MHD
Projects
None yet
Development

No branches or pull requests

1 participant