Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable FPE traps in CI #611

Draft
wants to merge 2 commits into
base: development
Choose a base branch
from
Draft

Conversation

BenWibking
Copy link
Collaborator

@BenWibking BenWibking commented Apr 17, 2024

Description

Enables signal handling and FPE traps for NANs, so it will stop and report an error when NANs are encountered when running the automated tests. This only works on CPUs.

In order for this to work, we change the signal handling settings back to AMReX defaults.

Related issues

Partially resolves #556.

Checklist

Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an x inside the square brackets [ ] in the Markdown source below:

  • I have added a description (see above).
  • I have added a link to any related issues see (see above).
  • I have read the Contributing Guide.
  • I have added tests for any new physics that this PR adds to the code.
  • I have tested this PR on my local computer and all tests pass.
  • I have manually triggered the GPU tests with the magic comment /azp run.
  • I have requested a reviewer for this PR.

@BenWibking
Copy link
Collaborator Author

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

@psharda psharda added enhancement New feature or request floating-point issue with floating-point roundoff error CI labels Apr 17, 2024
@psharda
Copy link
Contributor

psharda commented Apr 29, 2024

/azp run

Copy link

Azure Pipelines successfully started running 5 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement New feature or request floating-point issue with floating-point roundoff error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compile and run test suite with hipcc + FPE traps on CPU
2 participants