Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLLD solver sets flux for passive scalars to zero #560

Open
BenWibking opened this issue Mar 12, 2024 · 0 comments
Open

HLLD solver sets flux for passive scalars to zero #560

BenWibking opened this issue Mar 12, 2024 · 0 comments
Labels
bug Something isn't working MHD
Milestone

Comments

@BenWibking
Copy link
Collaborator

Describe the bug
The HLLD solver sets the flux for passive scalars (including mass scalars) to zero:

// TODO(neco): Eint=0 for now; pscalars will also be needed in the future.

(Within the Riemann solver, the passive scalars should be treated the same as the transverse momentum components.)

Additional context
Problems with passive scalars or mass scalars will not work correctly until this is added.

@BenWibking BenWibking added bug Something isn't working MHD labels Mar 12, 2024
@BenWibking BenWibking added this to the MHD milestone Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MHD
Projects
None yet
Development

No branches or pull requests

1 participant