-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load rocm for setonix CPUs #571
Conversation
/azp run |
Azure Pipelines successfully started running 5 pipeline(s). |
For production runs on CPUs, it might be better to avoid the Cray compiler altogether and use gcc instead. |
scripts/setonix-cpu.profile
Outdated
|
||
# GPU-aware MPI | ||
export MPICH_GPU_SUPPORT_ENABLED=0 | ||
|
||
# compiler environment hints | ||
export CC=$(which cc) | ||
export CXX=$(which CC) | ||
export CXX="$(which CC) -fno-cray" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenWibking will this fix #566 for CPUs? Will it work even if the compiler is not cray?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably a better idea to detect the cray compiler based on the value of CMAKE_CXX_COMPILER_ID
, e.g.
Line 79 in a2acbb7
if(CMAKE_CUDA_COMPILER_ID STREQUAL "Clang") |
except the appropriate compiler ID is "CrayClang" (https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_COMPILER_ID.html).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, put it in the wrong place
Ugh, using |
@chongchonghe got it to work on Setonix -- maybe @chongchonghe can help? |
On top of the setonix-gpu.profile, I have to add |
But it works if you add |
If I add |
So then |
It should be possible to avoid the Cray compiler entirely on Setonix. Then no special options should be necessary. This should be possible by loading
|
This by itself does not seem to be sufficient. We still need HDF5 and ROCm for example. When I load HDF5 and ROCm modules and
|
I still have some cray modules loaded. Is this an issue:
|
I think this is a better solution: #566. |
Since there is no activity on this for the past 2 months, I am going to close this issue for now. If it turns out to be needed, we can re-open it. |
Description
We need to load rocm while compiling on setonix CPUs.
Related issues
Fixes #563
Checklist
Before this pull request can be reviewed, all of these tasks should be completed. Denote completed tasks with an
x
inside the square brackets[ ]
in the Markdown source below:/azp run
.