Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent to show txs where origin and destination are the same address #46

Closed
trinityprivacy opened this issue Feb 18, 2024 · 1 comment

Comments

@trinityprivacy
Copy link

Hi, can you add this feature, especially on Sentinel Whale Monitor as it has being spammed?

@freak12techno
Copy link
Collaborator

As discussed per DM: it’s tricky as the filters are set the following way: xxxx.yyyy = zzzz, where xxxx and yyyy are keys and zzzz is a value, so like for sends it’s something similar to

transfer.amount > 10000000000000

Something like this

transfer.sender != transfer.recipient

wont work as zzzz is a value, not another key, and having a workaround in the app itself hardcoded to exclude these kinds of txs is ugly, as 1) likely its not the only way to abuse it, as they can just do another wallet and send txs between then, and 2) having an extra case to exclude specific cases adds extra complexity to the app.

So generally speaking, it's possible but quite pointless and will add the extra complexity event the app without the need for it, so I'd rather leave it as it is.

@freak12techno freak12techno closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants