Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The order of imports is unstable #51

Closed
KitsuneRal opened this issue Feb 9, 2019 · 1 comment
Closed

The order of imports is unstable #51

KitsuneRal opened this issue Feb 9, 2019 · 1 comment
Assignees
@KitsuneRal
Labels
bug
Projects
GTAD 1

Comments

@KitsuneRal
Copy link
Member

Since the list of imports is internally an unordered_set, the order of entries in it may change between runs, even if input files are intact. This breaks build reproducibility and adds unnecessary diffs if generated files are kept under version control.
@KitsuneRal KitsuneRal created this issue from a note in GTAD 1 (Version 0.7 - To Do) Feb 9, 2019
@KitsuneRal KitsuneRal added the bug label Feb 9, 2019
@KitsuneRal
Copy link
Member Author

The way forward is to integrate with clang-format to order #includes, among other things.

GTAD 1 automation moved this from Version 0.7 - To Do to Version 0.7 - Done Jun 27, 2019
@KitsuneRal KitsuneRal self-assigned this Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
bug
Projects
GTAD 1
  
Version 0.7 - Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KitsuneRal