Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuous room timeline #290

Open
KitsuneRal opened this issue Feb 27, 2019 · 1 comment
Open

Discontinuous room timeline #290

KitsuneRal opened this issue Feb 27, 2019 · 1 comment
Labels
enhancement A feature or change request for the library

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Feb 27, 2019

This is necessary to enable cases such as: resolving an event permalink (a part of #252); fixing #232; dropping parts of timeline to save memory; and others. One way to implement it would be to deploy several timeline objects in the room and provide indexing across them (employed in other clients including Riot; harder for clients to use since there's no single data source). Another (possibly more robust but less flexible and likely more challenging) way is to allow the deque used now to be discontinuous (e.g. by means of inserting 'more events here' markers where gaps are expected and auto-downloading events when these markers are about to show on the screen).

@KitsuneRal KitsuneRal added this to Version 0.6 in libQuotient 1 Feb 27, 2019
@KitsuneRal KitsuneRal added the enhancement A feature or change request for the library label Feb 27, 2019
@KitsuneRal
Copy link
Member Author

One particular application of this feature would be actually the opposite: seaming together timelines across room upgrades. Having different timeline objects for that purpose is more flexible as it allows to support different validations/behaviours depending on the room version the timeline is taken from (have a single AbstractRoomTimeline class and do version-specific behaviour in derived classes). A deque with markers is rather poor at extending to this case (baking the polymorphic behaviour into the container logic looks like a complete design failure).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
libQuotient 1
  
Version 1.0
Development

No branches or pull requests

1 participant