Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't swap dimensions for Bio-Formats using optional args #1036

Closed
petebankhead opened this issue Aug 18, 2022 · 0 comments · Fixed by #1041
Closed

Can't swap dimensions for Bio-Formats using optional args #1036

petebankhead opened this issue Aug 18, 2022 · 0 comments · Fixed by #1041
Assignees
Labels
Milestone

Comments

@petebankhead
Copy link
Member

Bug report

Describe the bug
It should be possible to swap dimensions when reading an image in Bio-Formats using option args, e.g. --dims XYTCZ, since #725

However, it doesn't work because of some confusion between the option name: --dims (for parsing) and --swap (serialized in the project).

Consequently, to see the effect in a project you need to open the JSON in a text editor and do a find and replace for all instances of --swap to become --dims.

To Reproduce
Steps to reproduce the behavior:

  1. Create a project
  2. Import a multidimensional image using Bio-Formats, with --dims XYTCZ or similar
  3. Open the image; the dimensions aren't swapped
  4. Check the project.qpproj file and look for instances of --dims... it won't be there, rather --swap will be instead.

Expected behavior
--dims should be stored in the project, when it is set as an optional arg.

Desktop (please complete the following information):

  • OS: All
  • QuPath Version: 0.3.2

Additional context
This was first noticed when investigating https://forum.image.sc/t/qupath-imagej-codex-swap-z-and-marker-channels/58565/15

Fixing this line might be all it takes:
https://github.com/qupath/qupath/blob/v0.3.2/qupath-extension-bioformats/src/main/java/qupath/lib/images/servers/bioformats/BioFormatsImageServer.java#L1609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant