Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vietnamese UI Translation #456

Closed
techyescountry opened this issue May 23, 2023 · 14 comments
Closed

Vietnamese UI Translation #456

techyescountry opened this issue May 23, 2023 · 14 comments

Comments

@techyescountry
Copy link
Contributor

Assalamualaykum,
If I want to translate the app UI, do i just clone one language in localization/resources folder, translate and send a pull request? Thank you

@mohamede1945
Copy link
Collaborator

We alikom elsalam we rahmat Allah we baraktoh,

We very much appreciate such an effort.

Yes you can clone and add a new folder for the Vietnamese language. Basically you can translate this file https://github.com/quran/quran-ios/blob/main/Sources/Localization/Resources/en.lproj/Localizable.strings. The other files are automatically imported from the Android repo, so if you translate them there, I'll make sure to sync before next release inshaa'Allah.

@ahmedre
Copy link

ahmedre commented May 23, 2023

Related to quran/quran_android#2284

@techyescountry
Copy link
Contributor Author

techyescountry commented May 24, 2023

@mohamede1945 I have also finished the Android translation, it would be great if you could import them from the Android repo. The Localizable.strings I have translated it but not sure if it works.

@techyescountry
Copy link
Contributor Author

Assalamualaykum, may i know roughly when will we have the next release?

@mohamede1945
Copy link
Collaborator

I'll try to test this later today inshaa'Allah and let you know.

As for the next release schedule. It may take sometime (maybe 2 months) as I have been doing some refactoring and would like to complete it and take enough time to test the changes before releasing it.

@techyescountry
Copy link
Contributor Author

I see. Ok inshaallah. Pls update me if the translation works fine with the ui layout.

@mohamede1945
Copy link
Collaborator

Apparently there are some changes in the Android repo that made my script that transforms android localization to iOS localization fail. I'll not be able to import them now. I'll try to do that before the release because I wanna fix the script once in case it breaks again.

For the time being here is a screenshot of the Settings app using only the localization you provided for iOS.

image

@mohamede1945
Copy link
Collaborator

One additional question if you don't mind, the name of the app in English is "Quran". Would that work in Vietnamese or do we need to change it?

@techyescountry
Copy link
Contributor Author

One additional question if you don't mind, the name of the app in English is "Quran". Would that work in Vietnamese or do we need to change it?

"Kinh Quran" would be better for the app. But on Appstore listing i think putting the title as "Kinh Quran - Cô ran" as Quran is pronounced as Cô ran in vietnamese

@techyescountry
Copy link
Contributor Author

Apparently there are some changes in the Android repo that made my script that transforms android localization to iOS localization fail. I'll not be able to import them now. I'll try to do that before the release because I wanna fix the script once in case it breaks again.

For the time being here is a screenshot of the Settings app using only the localization you provided for iOS.

image

MashaAllah, that's looks great. Maybe i'll copy the other xml files from en folder and translate it so you wont have troubles importing from the android project.

@mohamede1945
Copy link
Collaborator

Maybe i'll copy the other xml files from en folder and translate it so you wont have troubles importing from the android project.

Appreciate your offer for help. But I have to fix the script this will help me with other languages as well and ensuring consistency across both apps. So, I don't want you to spend time on something that I'll have to fix anyway.

@techyescountry
Copy link
Contributor Author

Maybe i'll copy the other xml files from en folder and translate it so you wont have troubles importing from the android project.

Appreciate your offer for help. But I have to fix the script this will help me with other languages as well and ensuring consistency across both apps. So, I don't want you to spend time on something that I'll have to fix anyway.

Ok brother, take care. Jazakallah Khairan.

@mohamede1945
Copy link
Collaborator

You are the one to be thanked. I appreciate your contribution a lot. May Allah reward you immensely

@mohamede1945
Copy link
Collaborator

Thank you brother @techyescountry! The new translation has been released for over a month now I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants