Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on PyPi #24

Closed
4 tasks done
mikegerber opened this issue Aug 13, 2020 · 6 comments
Closed
4 tasks done

Release on PyPi #24

mikegerber opened this issue Aug 13, 2020 · 6 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mikegerber
Copy link
Member

mikegerber commented Aug 13, 2020

@mikegerber mikegerber self-assigned this Aug 13, 2020
@mikegerber mikegerber added the enhancement New feature or request label Aug 13, 2020
@mikegerber mikegerber added this to the 1.0 milestone Sep 24, 2020
@mikegerber
Copy link
Member Author

This should reuse the workflow from setuptools-ocrd. We already have pyproject.toml, just need to enable the workflow.

@mikegerber
Copy link
Member Author

This is half-done:

https://pypi.org/project/dinglehopper/

There's a source up there with version 0.9.1, but the GitHub release has the source with this correction version and a wheel with version 0.0.0 - I suspect there is still a bug with setuptools_ocrd.

@mikegerber
Copy link
Member Author

❯ pip install dinglehopper
Collecting dinglehopper
  Downloading dinglehopper-0.9.1.tar.gz (35 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Discarding https://files.pythonhosted.org/packages/f6/fa/008dfaf8d3be2fb55ae7bba335fc868803822c27d331bf4deaecdc162808/dinglehopper-0.9.1.tar.gz (from https://pypi.org/simple/dinglehopper/) (requires-python:>=3.6): Requested dinglehopper from https://files.pythonhosted.org/packages/f6/fa/008dfaf8d3be2fb55ae7bba335fc868803822c27d331bf4deaecdc162808/dinglehopper-0.9.1.tar.gz has inconsistent version: expected '0.9.1', but metadata has '0.0.0'
[...]

@mikegerber
Copy link
Member Author

mikegerber commented Aug 4, 2023

❯ pip install --upgrade dinglehopper
Collecting dinglehopper
  Downloading dinglehopper-0.9.2-py3-none-any.whl (46 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 46.8/46.8 kB 375.3 kB/s eta 0:00:00

dinglehopper now installs cleanly from PyPI 🚀

This currently involves a workaround in MANIFEST.in and needs to be fixed properly here: qurator-spk/setuptools_ocrd#10

@mikegerber
Copy link
Member Author

This currently involves a workaround in MANIFEST.in and needs to be fixed properly here: qurator-spk/setuptools_ocrd#10

setuptools_ocrd 0.0.18 has this fixed and the workaround is removed!

@mikegerber
Copy link
Member Author

And README now recommends installing from PyPI

🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant