Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODS "name" changes #1

Open
mikegerber opened this issue Feb 21, 2022 · 3 comments
Open

MODS "name" changes #1

mikegerber opened this issue Feb 21, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@mikegerber
Copy link
Member

mikegerber commented Feb 21, 2022

The mods:name now has a mods:nameIdentifier:

/home/mike/devel/qurator-mono-repo/modstool/qurator/modstool/modstool.py:428: UserWarning: Exception in /srv/digisam_mets/PPN1678618276.xml:
Unknown tag "{http://www.loc.gov/mods/v3}nameIdentifier"
  warnings.warn('Exception in {}:\n{}'.format(mets_file, e))

Also, the mods:name/mods:displayForm (optional according to DFG MODS-Anwendungsprofil) got dropped in favor of the mandatory name part fields.

@mikegerber mikegerber added the bug Something isn't working label Feb 21, 2022
@mikegerber mikegerber self-assigned this Feb 21, 2022
@mikegerber
Copy link
Member Author

PPN1678618276.xml.txt

@mikegerber mikegerber changed the title Unknown tag "{http://www.loc.gov/mods/v3}nameIdentifier" MODS "name" changes Feb 21, 2022
@mikegerber
Copy link
Member Author

I've been unhappy with the kludgy name handling anyway, so perhaps it's time to handle this better.

@mikegerber mikegerber mentioned this issue Mar 30, 2022
2 tasks
@mikegerber
Copy link
Member Author

mikegerber commented Mar 31, 2022

As a first step, 93ce150 handles mods:nameParts in a straight-forward way and just exports the MODS structure into Pandas columns.

For the example above this is:

name0_namePart-given                                                                      ...
name0_namePart-family                                                                  Goebel
name0_role_roleTerm                                                                       aut
name1_namePart                                                              B. Schott's Söhne
name1_role_roleTerm                                                                       oth

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant