Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing subject/topic, genre #24

Open
1 task done
mikegerber opened this issue Apr 20, 2023 · 3 comments
Open
1 task done

Missing subject/topic, genre #24

mikegerber opened this issue Apr 20, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikegerber
Copy link
Member

mikegerber commented Apr 20, 2023

From the feedback by Maria Federbusch:

PPN813655765
Zusätzlich fehlen in diesem Beispiel (MONO) noch die Schlagwörter - hier aus dem ARMA-Projekt:

<mods:subject authority="getty">
<mods:topic valueURI="http://vocab.getty.edu/aat/300411614">reading culture</mods:topic>
<mods:topic valueURI="http://vocab.getty.edu/aat/300020756">Medieval (European)</mods:topic>
</mods:subject>
<mods:subject authority="wikidata">
<mods:topic valueURI="https://www.wikidata.org/wiki/Q107274053">Reading culture (medieval)</mods:topic>
</mods:subject>
<mods:genre valueURI="https://www.wikidata.org/wiki/Q1261026" type="class" authority="wikidata">
<mods:genre>printed matter</mods:genre>
</mods:genre>
  • Review a. DFG MODS Anwendungsprofil for mods:genre and b. more examples of mods:genre - here the structure is clearly different from the mods:subject examples. Would make more sense if the nested genre had the valueURI?
@mikegerber mikegerber self-assigned this Apr 20, 2023
@mikegerber mikegerber added the enhancement New feature or request label Apr 20, 2023
@mikegerber
Copy link
Member Author

mikegerber commented Apr 20, 2023

The thing I am thinking about here is

  1. how to encode both the IDs and the textual representation. Considering two arrays (not sets)
  2. if the topics/genre are ordered.

If we use two arrays (nested CSV basically), we also don't need to worry if there's an order because we just use the one from the file.

@mikegerber
Copy link
Member Author

mikegerber commented Apr 21, 2023

Relatively sure that we're going to translate this twice: once the IDs, and once the text, in the same order.

For mods:genre I asked Maria again because this example above looks incorrect and should be without the second mods:genre:

<mods:genre valueURI="https://www.wikidata.org/wiki/Q1261026" type="class" authority="wikidata">
printed matter
</mods:genre>

DFG MODS Anwendungsprofil Abschnitt 2.3.1 also looks like my corrected version. Haven't checked the XML Schema yet.

@mikegerber
Copy link
Member Author

The nested mods:genre is definitely incorrect, but I'm considering correcting it while the source files have this flaw.

@mikegerber mikegerber mentioned this issue Oct 25, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant