Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging inconsistency #50

Closed
bertsky opened this issue Oct 10, 2022 · 4 comments
Closed

packaging inconsistency #50

bertsky opened this issue Oct 10, 2022 · 4 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Oct 10, 2022

If I run sbb_binarize --version, I get:

Traceback (most recent call last):
  File "/bin/sbb_binarize", line 8, in <module>
    sys.exit(main())
  File "/lib/python3.6/site-packages/click/core.py", line 1128, in __call__
    return self.main(*args, **kwargs)
  File "/lib/python3.6/site-packages/click/core.py", line 1052, in main
    with self.make_context(prog_name, args, **extra) as ctx:
  File "/lib/python3.6/site-packages/click/core.py", line 914, in make_context
    self.parse_args(ctx, args)
  File "/lib/python3.6/site-packages/click/core.py", line 1370, in parse_args
    value, args = param.handle_parse_result(ctx, opts, args)
  File "/lib/python3.6/site-packages/click/core.py", line 2347, in handle_parse_result
    value = self.process_value(ctx, value)
  File "/lib/python3.6/site-packages/click/core.py", line 2309, in process_value
    value = self.callback(ctx, self, value)
  File "/lib/python3.6/site-packages/click/decorators.py", line 383, in callback
    ) from None
RuntimeError: 'sbb_binarize' is not installed. Try passing 'package_name' instead.

Looks like the name=sbb_binarization kwarg is not consistent with the top-level module sbb_binarize IINM.

Maybe you want to restructure your package using qurator as namespace package on that occasion?

@cneud
Copy link
Member

cneud commented Oct 11, 2022

Maybe you want to restructure your package using qurator as namespace package on that occasion?

Yes, that should be the way, we will try to do so asap.

@bertsky
Copy link
Contributor Author

bertsky commented Apr 14, 2023

fixed by #59 (strange the autolinking did not work)

@bertsky bertsky closed this as completed Apr 14, 2023
@cneud
Copy link
Member

cneud commented Apr 14, 2023

strange the autolinking did not work

Yes I noticed the same for other issues closed by #59, but deliberately kept this open since I think it may make sense to refactor sbb_binarize to sbb_binarization. But I will now track that in a new issue on our internal GitLab.

@bertsky
Copy link
Contributor Author

bertsky commented Apr 14, 2023

but deliberately kept this open since I think it may make sense to refactor sbb_binarize to sbb_binarization.

oh, sry about that.

You might even want to move to the qurator namespace...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants