Add new API for automatic login #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All seems god but would it not be sensible to return a 401 status if the authentication failed rather than a 200 with an error message. This would make checking for success easier. Should this be tested with an ajax call as well as with an iframe? This might work differently with session cookies - perhaps ajax calls would not set the cookie? |
|
OK proper status codes are now implemented. As discussed ajax/xhr calls only allow cookies with specific CORS headers (not compatible with our current default CORS headers) and even then are still subject to "3rd party cookie" rules so I believe Safari will still reject them by default. Do you have any other feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new API and documentation for how to log in to QIS from a 3rd party application so that images in a private folder can be viewed in the browser.