Get proper settings object in WebEngineElement._click_js

qutebrowser · Jun 6, 2017 · f9b046d · f9b046d
1 parent a7413d7
commit f9b046d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/qutebrowser/browser/webengine/webengineelem.py b/qutebrowser/browser/webengine/webengineelem.py
@@ -199,7 +199,10 @@ def _click_editable(self, click_target):
         self._move_text_cursor()
 
     def _click_js(self, _click_target):
-        settings = QWebEngineSettings.globalSettings()
+        # FIXME:qtwebengine Have a proper API for this
+        # pylint: disable=protected-access
+        settings = self._tab._widget.settings()
+        # pylint: enable=protected-access
         attribute = QWebEngineSettings.JavascriptCanOpenWindows
         could_open_windows = settings.testAttribute(attribute)
         settings.setAttribute(attribute, True)