Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip emojis from titles on old Qt versions #3746

Open
The-Compiler opened this issue Mar 21, 2018 · 1 comment
Open

Strip emojis from titles on old Qt versions #3746

The-Compiler opened this issue Mar 21, 2018 · 1 comment
Labels
bug: segfault/crash/hang There's a low-level crash in C++, or a hang/freeze. priority: 2 - low Issues which are currently not very important.

Comments

@The-Compiler
Copy link
Member

On older Qt versions (< 5.10?) there are issues with rendering emojis in labels - either there's rendering issues, or there's segfaults like those:

Current thread 0x00007f8abac2f700 (most recent call first):
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 510 in _text_to_width
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 512 in _minimum_tab_size_hint_helper
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 494 in minimumTabSizeHint
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 553 in tabSizeHint
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 152 in _update_tab_title
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabwidget.py", line 120 in set_page_title
  File "/usr/lib64/python3.6/site-packages/qutebrowser/mainwindow/tabbedbrowser.py", line 589 in on_title_changed
  File "/usr/lib64/python3.6/site-packages/qutebrowser/app.py", line 149 in qt_mainloop
  File "/usr/lib64/python3.6/site-packages/qutebrowser/app.py", line 139 in run
  File "/usr/lib64/python3.6/site-packages/qutebrowser/qutebrowser.py", line 188 in main
  File "/usr/lib/python-exec/python3.6/qutebrowser", line 11 in <module>

Current thread 0x00007f857b45e740 (most recent call first):
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/completion/completiondelegate.py", line 169 in _draw_textdoc
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/completion/completiondelegate.py", line 141 in _draw_text
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/completion/completiondelegate.py", line 282 in paint
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/app.py", line 149 in qt_mainloop
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/app.py", line 139 in run
  File "/usr/local/lib/python3.6/dist-packages/qutebrowser/qutebrowser.py", line 188 in main
  File "/usr/local/bin/qutebrowser", line 11 in <module>

We should probably just strip them.
@The-Compiler The-Compiler added priority: 2 - low Issues which are currently not very important. bug: segfault/crash/hang There's a low-level crash in C++, or a hang/freeze. labels Mar 21, 2018
@The-Compiler
Copy link
Member Author

Apparently this is still an issue on Qt 5.10.1

@Dieterbe Dieterbe mentioned this issue Jan 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: segfault/crash/hang There's a low-level crash in C++, or a hang/freeze. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@The-Compiler