Double reloading when using :reload after enabling JS

[The-Compiler]

Just noticed that, haven't investigated at all yet:

• Open two tabs (e.g. GitLab) which don't have JS allowed
• Allow JS in tab 1 (reloads as expected)
• Go to tab 2 and reload to enable JS there
• qutebrowser reloads a second time when reloading finished, because it probably doesn't get that the first reload suffices.

Though that makes me wonder whether qutebrowser should just reload all affected tabs automatically when a setting changes...

[toofar]

because it probably doesn't get that the first reload suffices.

Why does it even want to reload? I thought the reload when enabling JS was just from the binded command?

[The-Compiler]

The problem is that qutebrowser needs to toggle those setting before a page gets loaded. In most cases, this is caused by a on_predicted_navigation signal which qutebrowser emits before a navigation - but in the cases where that doesn't work, it reloads the page.

[toofar]

Speaking of that workaround, I just had a crash (the first one in ... ages) at https://github.com/qutebrowser/qutebrowser/blob/bc9a8dd/qutebrowser/browser/webengine/webenginetab.py#L1030 saying "RuntimeError: wrapped C/C++ object of type WebEngineView has been deleted" (meaning self I guess). The last line of the trace was from self._widget.load(url) in openurl. I think I just closed a tab and switched workspaces but I wasn't paying attention.