Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle exceptions in the non-main thread properly #3988

Open
The-Compiler opened this issue Jun 11, 2018 · 0 comments
Open

Handle exceptions in the non-main thread properly #3988

The-Compiler opened this issue Jun 11, 2018 · 0 comments
Labels
priority: 2 - low Issues which are currently not very important.

Comments

@The-Compiler
Copy link
Member

If an exception happens in the non-main thread, we currently try to invoke the exception dialog from a non-main thread, which causes a lot of further trouble (accessing sqlite and doing GUI-stuff from the wrong thread).

Instead, we should probably check what the current thread is, and do something more sane. This might also make @utils.prevent_exceptions unnecessary, at least in some scenarios.

@The-Compiler The-Compiler added the priority: 2 - low Issues which are currently not very important. label Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: 2 - low Issues which are currently not very important.
Projects
None yet
Development

No branches or pull requests

1 participant