Enabling JS for IPv6 Address fails

[merspieler]

When I try to enable js for an IPv6 Address with the default tshbinding i get the following error message:

ERROR | message | message:error:63 | Error while parsing *://<IPv6 Address>/*: Invalid port: invalid literal for int() with base 10: '<IPv6 Address>'

[merspieler]

Any update on this?

[The-Compiler]

The URL match patterns are ported from Chromium's match patterns - at the time I implemented/ported them, they didn't support IPv6 addresses in Chromium either.

However, it looks like support for that was added to Chromium, incidentally a few hours after you opened this issue 😆

So all that needs to be done is porting those changes (and the associated tests) to qutebrowser's urlmatch.py and test_urlmatch.py. I probably won't work on that anytime soon though.

[merspieler]

ok...

[tiemenv]

If someone is willing to give me some pointers I'd be glad to look into this

[The-Compiler]

@tiemenv Have you seen the links in my post above? Basically, the change in the linked commit needs to be ported from C++ to Python.

[The-Compiler]

As @DerJesko points out in #4118, parsing IPv6 addresses in UrlPattern works fine:

>>> urlmatch.UrlPattern('*://[2001:41d0:2:3b68::1]/*')
qutebrowser.utils.urlmatch.UrlPattern(pattern='*://[2001:41d0:2:3b68::1]/*')

so the issue you're actually seeing is with the tsh binding, similar to how it handles file:// URLs incorrectly. I thought there was an issue for that already, but I cn't find it right now.

[The-Compiler]

I don't think this should be closed yet, as tsh probably still doesn't work. Can't test it currently though, as I'm rarely in a network with IPv6 support 😟

[jgkamat]

Ah, that's true, I only tested the tsu binding(s). On my server http://[::1]:8080/ {url} is http://[::1]:8080/ and {url:host} is '::1'. This fails in the actual binding because it's not in square brackets (I'm guessing). I'm also not sure if this would be different if it wasn't just my toy server setup :P Florian Bruhin writes:

…

I don't think this should be closed yet, as tsh probably still doesn't work. Can't test it currently though, as I'm rarely in a network with IPv6 support 😟 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[lufte]

so the issue you're actually seeing is with the tsh binding, similar to how it handles file:// URLs incorrectly. I thought there was an issue for that already, but I cn't find it right now.

@The-Compiler I just ran into this file:// thing. Does the issue exist after all? I also couldn't find it.

[The-Compiler]

@lufte Nope, but I think it's the same underlying issue as this one.