Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not (fully) change applications Icon (macOS) #4009

Open
johnallen3d opened this issue Jun 19, 2018 · 6 comments
Open

Can not (fully) change applications Icon (macOS) #4009

johnallen3d opened this issue Jun 19, 2018 · 6 comments
Labels
component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important.

Comments

@johnallen3d
Copy link

I've changed the applications icon (no offense, I like to tinker) and the change is reflected in Finder, Spotlight etc. however not in the Dock or the Meta + Tab UI. I've made the chage by replacing the icon via the "Get Info" dialog as well as copying over /Applications/qutebrowser/Content/Resources/qutebrowser.icns with the same results. I've even gone so far as to try the steps listed in this Gist and serveral of the comments.

This is a shot in the dark but I thought I'd ask, is it possible the original icon is being set elsewhere?

Version info

qutebrowser v1.3.1
Git commit: ac29c579f-dirty (2018-05-29 11:14:01 +0200)
Backend: QtWebEngine (Chromium 61.0.3163.140)

CPython: 3.6.5
Qt: 5.10.0
PyQt: 5.10

sip: 4.19.8
colorama: 0.3.9
pypeg2: 2.15
jinja2: 2.10
pygments: 2.2.0
yaml: 3.12
cssutils: 1.0.2 $Id$
attr: 17.4.0
PyQt5.QtWebEngineWidgets: yes
PyQt5.QtWebKitWidgets: no
pdf.js: no
sqlite: 3.20.1
QtNetwork SSL: Secure Transport, macOS High Sierra (10.13)

Style: QWindowsStyle
Platform: Darwin-17.6.0-x86_64-i386-64bit, 64bit
Frozen: True
Imported from /Applications/qutebrowser.app/Contents/MacOS/qutebrowser
Qt library executable path: /Applications/qutebrowser.app/Contents/MacOS/PyQt5/Qt/libexec, data path: /Applications/qutebrowser.app/Contents/MacOS/PyQt5/Qt
OS Version: 10.13.5, x86_64
@toofar
Copy link
Member

toofar commented Jun 19, 2018

I don't know mac but the changed ones sound like they are coming from the installed application metadata and the ones that aren't are coming from the live process. Here we tell Qt to set the window icon, I'm not sure if that is what we are looking for but I suspect so. I don't know enough about the proccess of turning qutebrowser into an installable application for mac to know where those pngs end up, if they are even packaged, but if you can find any files from icons/ in the installed files it might be worth trying to switch them out.

@johnallen3d
Copy link
Author

Thanks for the response @toofar! I've looked around the contents of the packaged qutebrowser.app but do not see the icons in question anywhere. I'll have to read up a little bit on Qt (and maybe libqsvgicon.dylib) later to see if I can understand the process better.

@jgkamat
Copy link
Member

jgkamat commented Jun 19, 2018 via email

@johnallen3d
Copy link
Author

I have tried digging further through /Applications/qutebrowser.app/ but am unable to locate another icon file to replace. Perhaps it's compiled into an archive of some sort or cached somewhere by macOS (though I've tried clearing caches).

It does seem like Qt is providing two ways of setting the icon for a package. Here they discuss configuring the main icns file which is typically what you'd replace to change an icon and is present at /Applications/qutebrowser.app/Contents/Resources/qutebrowser.icns and defined in /Applications/qutebrowser.app/Contents/Info.plist. They also mention QWindow::setWindowIcon() here (and other places). I believe now, as @toofar theorized, this is what is setting the Dock icon. If it was possible to configure that as @jgkamat suggests or even have it point to ./Contents/Resources/qutebrowser.icns that would be great.

Obviously this isn't a high priority "issue", I appreciate you comments and consideration!

@The-Compiler The-Compiler added the status: needs triage Issues/PRs which need some deeper investigation. label Aug 1, 2018
@eggcaker
Copy link

eggcaker commented Nov 8, 2018

@johnallen3d did you success chnage the app icon ?

@johnallen3d
Copy link
Author

Sorry @eggcaker, no, I did not have any luck.

@The-Compiler The-Compiler added component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important. and removed status: needs triage Issues/PRs which need some deeper investigation. labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: config Issues related to configuration. priority: 2 - low Issues which are currently not very important.
Projects
None yet
Development

No branches or pull requests

5 participants