Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion delays while typing, even when completion.show == "auto" #4794

Open
NoSuck opened this issue May 21, 2019 · 1 comment · May be fixed by #5794
Open

completion delays while typing, even when completion.show == "auto" #4794

NoSuck opened this issue May 21, 2019 · 1 comment · May be fixed by #5794
Labels
component: completion Issues related to the commandline completion or history. component: performance Issues with performance/benchmarking. priority: 1 - middle Issues which should be done at some point, but aren't that important.

Comments

@NoSuck
Copy link

NoSuck commented May 21, 2019

Version info (see :version):
qutebrowser v1.6.2
Git commit:
Backend: QtWebEngine (Chromium 69.0.3497.128)

Does the bug happen if you start with --temp-basedir?:
No, of course not.

Description
I noticed that response while typing in the command bar is slow, even when completion.show is set to auto. It's as if history.sqlite is being queried ala always, just with hidden results. Perhaps @rcorre can confirm this?

I would expect the query to be executed when a completion is actually requested, e.g. completion-item-focus is called.

How to reproduce

  • Have a large ratio of history.sqlite size to computing capability.
  • Set completion.show to auto.
  • Enter the command bar with :open and start typing.
@jgkamat jgkamat added the component: performance Issues with performance/benchmarking. label May 21, 2019
@The-Compiler The-Compiler added component: completion Issues related to the commandline completion or history. priority: 1 - middle Issues which should be done at some point, but aren't that important. labels May 21, 2019
@rcorre
Copy link
Contributor

rcorre commented May 21, 2019

From a cursory glance at the code, I'd say you're right. completion.show only affects whether show is called on the widget. set_pattern is called whenever the text is changed, regardless of completion.show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: completion Issues related to the commandline completion or history. component: performance Issues with performance/benchmarking. priority: 1 - middle Issues which should be done at some point, but aren't that important.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants