Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS navigation events not added to history #5012

Open
vilhalmer opened this issue Sep 12, 2019 · 1 comment
Open

JS navigation events not added to history #5012

vilhalmer opened this issue Sep 12, 2019 · 1 comment
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. priority: 1 - middle Issues which should be done at some point, but aren't that important.

Comments

@vilhalmer
Copy link
Contributor

Version info (see :version):
qutebrowser v1.7.0
Git commit:
Backend: QtWebEngine (Chromium 73.0.3683.105)

CPython: 3.7.4
Qt: 5.13.0
PyQt: 5.13.0

sip: 4.19.18
colorama: no
pypeg2: 2.15
jinja2: 2.10.1
pygments: 2.4.2
yaml: 5.1.2
cssutils: no
attr: 19.1.0
PyQt5.QtWebEngineWidgets: yes
PyQt5.QtWebKitWidgets: no
pdf.js: 2.2.228 (/usr/share/pdf.js/build/pdf.js)
sqlite: 3.29.0
QtNetwork SSL: OpenSSL 1.1.1c 28 May 2019

Style: QFusionStyle
Platform: Linux-5.2.13-arch1-1-ARCH-x86_64-with-arch, 64bit
Linux distribution: Arch Linux (arch)
Frozen: False
Imported from /usr/lib/python3.7/site-packages/qutebrowser
Using Python from /usr/bin/python3
Qt library executable path: /usr/lib/qt/libexec, data path: /usr/share/qt

Paths:
cache: /run/user/1000/qutebrowser/default/cache
config: /run/user/1000/qutebrowser/default/config
data: /run/user/1000/qutebrowser/default/data
runtime: /run/user/1000/qutebrowser/default/runtime
system data: /usr/share/qutebrowser

Does the bug happen if you start with --temp-basedir?:
Yes

Description
Sites which use the JS history API for navigation do not cause entries to appear in QB's history, only the initially loaded page will be present.

@jgkamat thinks this behavior changed here: https://github.com/qutebrowser/qutebrowser/pull/4723/files#diff-f8b824a00e288dfd556db4ce56a7008fR1527

How to reproduce
Visit https://github.com/qutebrowser/qutebrowser and click on any file. The new URL will not appear in history.

@The-Compiler
Copy link
Member

@The-Compiler The-Compiler added bug: behavior Something doesn't work as intended, but doesn't crash. priority: 1 - middle Issues which should be done at some point, but aren't that important. labels Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. priority: 1 - middle Issues which should be done at some point, but aren't that important.
Projects
None yet
Development

No branches or pull requests

2 participants