Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password_fill does not work for elastic/kibana login form #5419

Open
twouters opened this issue May 7, 2020 · 2 comments
Open

password_fill does not work for elastic/kibana login form #5419

twouters opened this issue May 7, 2020 · 2 comments
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: userscripts Issues related to userscripts in misc/userscripts priority: 2 - low Issues which are currently not very important.

Comments

@twouters
Copy link

twouters commented May 7, 2020

Version info:
qutebrowser v1.11.1
Git commit:
Backend: QtWebEngine (Chromium 77.0.3865.129)
Qt: 5.14.2

Does the bug happen if you start with --temp-basedir?:
yes

Description
password_fill userscript does not fill username and password on elastic login form.
I'm not aware of a public server where this can be validated, but it looks sort of reproducible on their demo setup.

How to reproduce
Create a password store entry for demo.elastic.co with pass:

demo
username: demo

Head over to the account settings page for the demo user (https://demo.elastic.co/app/kibana#/account?_g=()) and run password_fill userscript to fill the password fields (like it does for most supported websites as far as I'm aware) and notice that the password fields remain empty.

@The-Compiler
Copy link
Member

Sorry, this got lost in my inbox. I don't use that userscript myself, but maybe someone who contributed to it in the past knows more? Taking the freedom to ping @t-wissmann @kepi, @paretje and @sarg who worked on the JavaScript part of the script in the past.

@The-Compiler The-Compiler added bug: behavior Something doesn't work as intended, but doesn't crash. priority: 2 - low Issues which are currently not very important. component: userscripts Issues related to userscripts in misc/userscripts labels Jul 22, 2020
@t-wissmann
Copy link
Contributor

The reason that this does not work is that on this password-reset-page, there is no html <form>. There are <input ..> fields, but they are not connected by a surrounding <form> tag. It is quite hacky already to put in the credentials into every form having a password input, I think it would be too hacky/risky to put in the username and password into every input field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behavior Something doesn't work as intended, but doesn't crash. component: userscripts Issues related to userscripts in misc/userscripts priority: 2 - low Issues which are currently not very important.
Projects
None yet
Development

No branches or pull requests

3 participants