-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommended build process for QtWebEngine with proprietary codecs #5466
Comments
Note you can run a newer qutebrowser version against Ubuntu's Qt, see the install instructions. |
Thanks @The-Compiler, I've had some issues there with the instructions. Using the 'link' method for the system-wide Qt, I get some codec errors when testing the browser against this page. AAC & MPEG4 do not play, but MPEG4 also does not play in Chromium either:
When using the 'source' method from the instructions, the install fails and I am not sure of the cause:
My goal is largely just to see how well I can cover all of the proprietary codecs, but I wasn't aware of any open issues regarding the codecs (if there are any). |
Those errors with |
Sure, I'll also just note here that the
|
That's still using a Qt bundled with PyQt5:
Are you sure you did run |
Yes, I just closed the browser, ran |
Okay, so you are probably shadowing Ubuntu's PyQt/Qt with an anaconda-installed PyQt or something. What does |
Ah, yes, you're correct, it shows:
I bypassed Anaconda, then fixed a bunch of missing Qt dependencies (which I'll document here later, since they're not mentioned in the install doc), and now the browser seems to work on all codec tests from that page. The downside seems to be that I am now using a very old version of Qt, being 5.9.5, so I'm guessing the I am very interested in seeing a Conda package for qutebrowser, negating the need for a .venv install and numerous |
A PR to the install docs would be great! You can even do that from inside GitHub FWIW.
True - support for Qt < 5.11 will probably be dropped in qutebrowser v2.0.
Note the
Something that might be good (because it comes up from time to time) is a general overview on how to compile PyQt/Qt and make qutebrowser use that. Then again, pretty much anyone attempting this (especially on Windows/macOS) has given up as far as I know, as building Qt is a pain even if it works (takes at least 16 GB of RAM and usually multiple hours to build, and you should do so with every updated release). edit: Another solution might be to upgrade to Ubuntu 20.04, FWIW.
I don't really see the benefit, but if someone wants to take up that task (and maintains the package), I'm fine with including that in the installation docs. |
I may do that, but I might create the Conda package first to lessen the need for instructions on every different OS, if I can figure out how to either reliably compile Qt or grab updated binaries. If there are any drawbacks with Conda in relation to qutebrowser, I would be interested to hear what they are.
There are still quite a few vendors who have not updated their software or documentation for 20.04, unfortunately, so that remains a barrier for me at least for the moment before upgrading. |
I have had a lot of issues with installing this on Ubuntu 20.04 earlier (recently mainly because Qt on this version is pretty old...) and managed to get codecs working with the help of Here's how:
I know this is necroposting, but maybe it'll help someone with the same issue I had, cheers! |
Similar issues on 20.04
Testing on http://demo.nimius.net/video_test/
:version output
The standard install from the Ubuntu repository appears to have similar issues on that site and neither version plays Udemy videos. I've seen quite a few issues where it seems that the suggestion is that proprietary codecs should not be an issue on the default install on Ubuntu 20.04. This hasn't been the case for me. |
According to:
You're not using Ubuntu's Qt, but one shipped with a binary PyQt install. I don't think this is the virtualenv you've created with |
That may be correct. I ran a Then I tried running qutebrowser again:
It is getting generated when I run mkvenv.py, so I'm not sure abou that. I also made sure to close other windows before running it for exactly the reason you stated. |
Solution run: Don't run: As it will just use the first Python3 in your PATH, not necessarily the system Python. Also, running Line 1 in a9e4aee
Which if codecs rely on using the system's python, won't work all that well. To quote a stack exchange answer on the topic:
I think the docs should specify that you need to use the absolute path to the system python when creating the virtualenv. We should also remove the shebang from the creation script so that it errors if somebody tries running it directly. Finally I think the Ubuntu 20.04 install instructions should be updated so that they stop claiming that people can just install it directly from apt as this will give them a very old version that doesn't even seem to use the codecs. Would you like me to create a PR for this? Off topic:
|
I disagree, at least as a general advice. There are reasons why you might want to use it with another Python, and if you changed your default Python, you should be aware of having done so. I think it's a good idea to clarify that
I don't think so, for the same reasons as above.
We should probably point to the virtualenv install method to get a newer install, but I'm against removing them entirely.
I don't follow, I'd expect those to work fine.
With the caveats above, yes please! |
It's one thing to be aware that you installed Python at some stage for some reason. It's quite another to understand how that interacts with the functioning of qutebrowser's install process. I think the current docs make a lot of assumptions about things that should be known by people wanting to try out qutebrowser. I don't think it's obvious how having another python3 installed impacts mkvenv.py:
|
I've been for years trying to build it, never got success... |
I've installed qutebrowser with pip to get a newer version than what was available from the Ubuntu (18.04) repo, since v1.1.1 has issues related to #5182. I was hoping to compile QtWebEngine from source to make use of the proprietary codecs, and was hoping to get some input on this, assuming others here do this semi-regularly (or would like to generalize the process).
I've found this gist, and was hoping others could point out any necessary modifications needed specifically for qutebrowser or anything that could further generalize it across platforms. I was hoping that if it can be sufficiently scripted, then maybe it could be included in
qutebrowser/scripts
to help others, and possibly documented in the install process. Thanks.The text was updated successfully, but these errors were encountered: