review: new and changed settings

[toofar]

There are several new and changed settings. Before we land the feature we have an opportunity to review them. Look for opportunities to align the new settings with existing ones, tweak them to make them more clear, or whatever other suggestions you have.

Here are some notes from me:

• new_positions setting names and descriptions are quite long. If you don't have a wide window it can be hard to see what they are talking about. Suggestion for the settings names: remove the new_ prefixes from the ones that have it. Suggestion for the descriptions: review for brevity and consistency.
• Do we need all of those new_position settings? Are some of them redundant? Eg why does demote need a different setting from new_child? Or promote different from new_sibling?
• new_child setting references --relative instead of --related
• should "new_child" be "related"? Seems a difference between the setting and the command arguments.
• probably want to change the default title format for tabs.title.format_pinned

[mschilli87]

@toofar: Whenever you feel like this becomes a priority, feel free to ping me for input. I did some work on standardising the config names and documentation some years back so I might be able to provide some context.

[toofar]

Thanks @mschilli87! I marked this as a blocker on the project board, so it's definitely a priority! If you want to pick this up, please feel free.

Fitting these new settings (and commands in #8074) neatly in amongst the existing ones is fairly important because everyone who wants to try out the feature will likely have to figure them out. If we can make sure everything is as logical and usable as possible that would be a big help.

I documented all the new and changed settings I could see in the docs in as non-judgemental a fashion as I could, and with my usual flawless spelling and grammar I see.

Getting timely reviews and feedback will likely continue to be an issue, so you'll probably have to be patient on that front. Possibly putting some extra effort into presenting options in a way that makes it easy to see all the complications and give feedback (eg, to vote) could help with pulling some people out of the woodwork. Although since session loading has been broken on the integration branch for a week and no-one complained, perhaps no-one is using it after all.

Anyway, sing out if you want to take this on or need any assistance!

[toofar]

Hmm, does anyone have any thoughts on whether tabs.select_on_remove needs to learn about tree stuff too? Eg with that set to prev and a tab structure like:

- one
  - two
- three (active)

if you close "three" then "two" would be selected. I think I would prefer that it went to the previous sibling, instead of into an unrelated tree group.