Changes to (_internal_)create_program() #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents Include measurements defined on subtemplates of multi channel templates
…ents Fix parameter_names and measurement_names
…encePT, ForLoopPT, AtomicPT (and thus all subclasses of that) + tests.
terrorfisch
approved these changes
Aug 2, 2018
qctoolkit/pulses/pulse_template.py
Outdated
| @@ -118,7 +118,7 @@ def create_program(self, *, | |||
| if parameters is None: | |||
| parameters = dict() | |||
| if measurement_mapping is None: | |||
| measurement_mapping = dict() | |||
| measurement_mapping = dict() # todo (2018-08-02): should not be empty but an identity mapping; requires PT to be a MeasurementDefiner (?) | |||
There was a problem hiding this comment.
measurement_names is an abstract property of PulseTemplate
| measurement_parameters = {parameter_name: parameters[parameter_name].get_value() | ||
| for parameter_name in self.measurement_parameters} | ||
| except KeyError as e: | ||
| raise ParameterNotProvidedException(str(e)) from e |
There was a problem hiding this comment.
Why do you create an exta dictionary for the measurement parameters? They should be a subset of parameter_names
There was a problem hiding this comment.
should be but currently aren't according to #230
| measurements = self.get_measurement_windows(measurement_parameters, measurement_mapping) | ||
| if self.duration.evaluate_numeric(**duration_parameters) > 0: |
There was a problem hiding this comment.
There should be a better way. But this is an optimization for the future.
… additional test for ForLoopPT._internal_create_program()
…easurement_mapping by replacing them with an identity mapping for all measurement names
terrorfisch
approved these changes
Aug 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of new signature PT._internal_create_program for RepetitionPT, SequencePT, ForLoopPT, AtomicPT (and thus all subclasses of that) + tests.
MappingPT is the only one missing now.
After that is done, #287 should be finished.