Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Travis Configuration #38

Merged
merged 8 commits into from
Jul 15, 2015
Merged

Working Travis Configuration #38

merged 8 commits into from
Jul 15, 2015

Conversation

lumip
Copy link
Contributor

@lumip lumip commented Jul 14, 2015

I've finally been able to come up with a configuration for Travis that works.
I've created a preliminary setup.py, which is used by Travis to run tests via the "setup.py test" command.

To ensure that imports in test modules work in any case (i.e. Travis and manual execution in eclipse) I had to change the way imports had been: Every test module now adds the src-folder to sys.path (instead of the concrete subfolder, e.g., src/pulses). Accordingly, imports in test modules must be made relative to that, e.g. import pulses.Parameter. This is the only solution I could come up with such that tests run in all required cases.

I also had to (temporarily) add the typing module from my Python 3.5.0b2 directory since Travis currently only features Python 3.5.0a2 which seems to no include it.

Any remarks or proposals for changes? @ekammerloher @j340m3

…c directory to sys.path. Module imports are made relative to this, e.g., pulses.Parameter. This works in any settings (executing single or all test modules in eclipse, running "setup.py test").
@lumip lumip mentioned this pull request Jul 14, 2015
@ekammerloher
Copy link
Member

I think it is a good design change to use a setup.py, since it conforms to usual practice. It will be easier to include dependencies and make our toolkit pip-installable.

Tools like Travis and Coveralls might not add too much value in the short term, but will help advertise our project as a serious development effort to the community in the long term and are good to keep track of development over time.

In this sense I also enabled coveralls.io and modified the README.md

@lumip
Copy link
Contributor Author

lumip commented Jul 14, 2015

Before we merge, I want to know whether or not @j340m3 is okay with the changes to the imports since I've basically reverted some of his recent work with that.

@j340m3
Copy link
Contributor

j340m3 commented Jul 15, 2015

If everything works, this looks fine for me. The changes to the import (i.e. try and except around it) where hotfixes from my side and not intended to be long term code.

@lumip lumip merged commit fab9b85 into master Jul 15, 2015
@lumip lumip deleted the travis branch July 15, 2015 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants