New Snapshot - 04-12 #186
Merged
New Snapshot - 04-12 #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ import libc | |||
| to this protocol | |||
| */ | |||
| public protocol LogDriver { | |||
| func log(level: Log.Level, message: String) | |||
| func log(_ level: Log.Level, message: String) | |||
There was a problem hiding this comment.
Missing Docs Violation: Public declarations should be documented. (missing_docs)
This was referenced Apr 22, 2016
| ("testSetValueForKey_setsValueCorrectly", | ||
| testSetValueForKey_setsValueCorrectly), | ||
| ("testSetValueForKey_withExistingValue_overwritesValueCorrectly", testSetValueForKey_withExistingValue_overwritesValueCorrectly), | ||
| ("testSetValueForKey_withExistingValue_toNilErasesValue", testSetValueForKey_withExistingValue_toNilErasesValue), |
There was a problem hiding this comment.
Line Length Violation: Line should be 100 characters or less: currently 125 characters (line_length)
| @@ -136,7 +174,7 @@ extension Application { | |||
| Create multiple routes with the same base URL | |||
| without repeating yourself. | |||
| */ | |||
| public func group(prefix: String, @noescape handler: () -> Void) { | |||
| public func group(_ prefix: String, @noescape handler: () -> Void) { | |||
There was a problem hiding this comment.
Valid Docs Violation: Documented declarations should be valid. (valid_docs)
There was a problem hiding this comment.
Valid Docs Violation: Documented declarations should be valid. (valid_docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test w/ this dependency: