-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Ezquake crash (on console-autocompletion IF vid_settings changed) #73
Comments
Thanks for reporting. We will look into is as soon as we get time. For future reference please read the simple rules in the wiki for issue reporting. Thanks |
I can't reproduce this.. Are you still experiencing the issue? |
yes, i can still reproduce this. I am using latest QRP textures (as probably most everybody) :) |
using 15.march nightly build, and it seems fixed. Can´t reproduce anymore since this one! |
ok i was a bit soon here. Still reoccuring. Changed no24bit , didnt restart client. I tried changing gamma via autocompletion no errors.... then i tried to change s_desiredsamples and hit TAB to complete, BOOM crash to desktop again. Still there! :( |
So is it no24bit toggling that causes it still? I'm wondering if you have some weirdo files in your quake or qw directory causing this... If you could try creating a new quake folder only containing original pak0.pak and pak1.pak (unmodiifed) and the .exe and see if you can reproduce, otherwise, just keep popping in the rest of your files one by one (pak/pk3 files) and then like texture folders until you hit what's causing it. |
ok i will try that reducing strategy (freshinstall) and check this weekend! |
Are you using nquake as base? |
I do believe you hehe, it's just that it's merely impossible to debug if I can't reproduce it :) |
This is where having a visual studio project would come in handy. Very easy for @onethree7 to simply install it and run via that (or attach to the process as it crahses) to get a full stack trace when the crash happens. But I guess the same thing could be done with gdb in mingw, just not as straight forward. |
@JoakimSoderberg Absolutely! How's your CMake pull request coming along? ;) |
:D |
hi guys, thanks for all the suggestions and feedback! I tried with a pak1+pak2.pak freshinstall from quake cd :D then copyied my ezquake exe and ezquake folder over. Tried to reproduce [always like this: 1) map dm4 2)gl_no24bit 1 3)vid_restart 4)map dm6 5) gl_gam(TAB) 6)s_des(TAB)] usually there it crashes. It crashed again here, so i had to look further. I began reducing the ezquake folder and found that the issue only occurs when a file called "base.pk3" is inside qw\ezquake\ . The other ,pk3 can be loaded fine without any issue. But as soon base.pk3 is there, i get this crash. Then i checked weather this is nquake or ezquake delivered :D Those files are in ezquake Full version i believe. My base.pk3 has the following md5 sum "c2282a0426931cb13f0a28aa5f5246aa". As for debugging, im totally clueless sadly. I have visual studio 2015 installed, but whenever im hitting debug after the crash, my debugger crashes :D ;D guess thats windows^^ |
one correction on reproducing its not at step 2)gl_no24bit 1, its 0!!! as i switch from using it to not using it (sorry) Edit: Concerning your question: Are you using nquake as base? |
The version of base.pk3 I am using has a different md5 sum ("52c9baeb5618f3d7c67572ec8621ecfd"), available from the full install of ezquake 2.1, here Can you test with that version, and if that doesn't crash (fingers crossed) we can take it from there to work out what the differences are? |
I was able to reproduce this fairly easy by following the steps. Just that I can't recall what gdb told me :( I'll see if I can get my memory straight and update this post with what I found, but I think it had something to do with the cache ... Hmm, some small memory fragments coming back while writing: It was something with hash buckets in the fs.. fs_nocache 1 "solved" the issue IIRC.... |
…ed 1>0 VX_STUFF was registering commands (gl_checkmodels/gl_inferno/gl_setmode) in a function only called when gl_no24bit was set to 0. The commands use Hunk_Alloc(), so the newly added commands at the front of the linked list were being allocated in memory that was free'd on the next map change, and the client would inevitably crash when next finding commands in the list. Fixes bug QW-Group#73
<3 <3 <3 |
Good to hear. It was my mistake when trying to reproduce it, your steps worked perfectly. Thanks for spending the time and working it out. |
I can reproduce a crash by:
-opening EZQUAKE with gl_no24bit 1 (saved in config)
-game open & via console: gl_no24bit 0 , + vid_restart
-FOR EXAMPLE: now change gamma... type gl_ga (HIT TAB, to get autocompletion)
-crashes.
Crashes on other GL_ or Vid_ related commands then. Not sure about others.
(Windows 7, 64bit, latest+nightly)
The text was updated successfully, but these errors were encountered: